Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: disallow upgrade from below 6.2 to current master #56659

Closed

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Oct 15, 2024

What problem does this PR solve?

Issue Number: close #56658

Problem Summary:

What changed and how does it work?

as title. code related to old ddl job queue will removed in later PR

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

upgrade from 6.1.0 -> master, fail with error:
[2024/10/15 18:32:46.726 +08:00] [FATAL] [terror.go:309] ["unexpected error"] [error="Cannot upgrade from below v6.2.0 to this version, please upgrade to a version in range [v6.2.0, v8.5.0) first. Current bootstrap version is 91, target version is 216"] [stack="............."]

upgrade from 6.2.0/8.1.0 -> master, success

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2024
Copy link

tiprow bot commented Oct 15, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.8215%. Comparing base (83c4a0f) to head (ad9d713).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56659         +/-   ##
=================================================
- Coverage   73.3976%   56.8215%   -16.5762%     
=================================================
  Files          1629       1753        +124     
  Lines        450073     630117     +180044     
=================================================
+ Hits         330343     358042      +27699     
- Misses        99467     247762     +148295     
- Partials      20263      24313       +4050     
Flag Coverage Δ
integration 37.8082% <53.3333%> (?)
unit 72.5273% <60.0000%> (-0.0054%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1123% <ø> (+17.5655%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 16, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 16, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2024
@Benjamin2037
Copy link
Collaborator

May need let Tester who own upgrade testing know this change and do changes according.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024
Copy link

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-16 06:35:35.115915341 +0000 UTC m=+425732.264825158: ☑️ agreed by Benjamin2037.
  • 2024-10-16 06:48:32.789711303 +0000 UTC m=+426509.938621127: ☑️ agreed by tangenta.

Copy link

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, tangenta
Once this PR has been reviewed and has the lgtm label, please assign yudongusa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@D3Hunter D3Hunter changed the title bootstrap: disable upgrade from below 6.2 to current master bootstrap: disallow upgrade from below 6.2 to current master Oct 16, 2024
@jebter
Copy link

jebter commented Oct 16, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024
@D3Hunter
Copy link
Contributor Author

just found out that we have already remove the code of DDLForce2Queue=true when forcing the new node to be owner in https://github.com/pingcap/tidb/pull/51285/files#diff-2fde3341e0231e7b162880b36f07d23b7949ca512c5536b50706ac5aa9072b25L1484

so the limitation in this PR is not needed

@D3Hunter D3Hunter closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable upgrade from below 6.2 to current master(8.5+)
5 participants