-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: disallow upgrade from below 6.2 to current master #56659
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56659 +/- ##
=================================================
- Coverage 73.3976% 56.8215% -16.5762%
=================================================
Files 1629 1753 +124
Lines 450073 630117 +180044
=================================================
+ Hits 330343 358042 +27699
- Misses 99467 247762 +148295
- Partials 20263 24313 +4050
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
May need let Tester who own upgrade testing know this change and do changes according. |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 3pointer, Benjamin2037, tangenta The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
just found out that we have already remove the code of so the limitation in this PR is not needed |
What problem does this PR solve?
Issue Number: close #56658
Problem Summary:
What changed and how does it work?
as title. code related to old ddl job queue will removed in later PR
Check List
Tests
upgrade from 6.1.0 -> master, fail with error:
[2024/10/15 18:32:46.726 +08:00] [FATAL] [terror.go:309] ["unexpected error"] [error="Cannot upgrade from below v6.2.0 to this version, please upgrade to a version in range [v6.2.0, v8.5.0) first. Current bootstrap version is 91, target version is 216"] [stack="............."]
upgrade from 6.2.0/8.1.0 -> master, success
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.