Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: improve visualization of br #56612

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 12, 2024

What problem does this PR solve?

Issue Number: close #56493

Problem Summary:
See the issue.

What changed and how does it work?

add more details in the summary. And split the progress of snapshot restore

Detail BR log in /tmp/br.log.2024-10-12T15.39.51+0800 
Split&Scatter Region <----------------------------------------------------------------------------------------------------> 100.00%
Download&Ingest SST <-----------------------------------------------------------------------------------------------------> 100.00%
Restore Pipeline <--------------------------------------------------------------------------------------------------------> 100.00%
[2024/10/12 15:47:55.497 +08:00] [INFO] [collector.go:77] ["Full Restore success summary"] [total-ranges=863] [ranges-succeed=863] [ranges-failed=0] [merge-ranges=7.546971ms] [split-region=343.594072ms] [restore-files=5m3.576621503s] [default-CF-files=278] [write-CF-files=558] [split-keys=386] [total-take=6m35.304887635s] [total-kv=871760372] [total-kv-size=143.8GB] [average-speed=363.8MB/s] [restore-data-size(after-compressed)=62.07GB] [Size=62072785167] [BackupTS=452625823236882437] [RestoreTS=453237563041775617]

merge-ranges: the time consumption of ranges merge.
split-region: the time consumption of regions split&scatter.
restore-files: the time consumption of SST files download&ingest.
default-CF-files: the number of default CF files.
write-CF-files: the number of write CF files.
split-keys: the number of keys to split regions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Oct 12, 2024
Copy link

ti-chi-bot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from leavrth, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 12, 2024
Copy link

tiprow bot commented Oct 12, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 78.44311% with 36 lines in your changes missing coverage. Please review.

Project coverage is 56.9008%. Comparing base (9b1fa1c) to head (ec04b38).
Report is 36 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56612         +/-   ##
=================================================
- Coverage   73.4078%   56.9008%   -16.5071%     
=================================================
  Files          1626       1754        +128     
  Lines        449038     632738     +183700     
=================================================
+ Hits         329629     360033      +30404     
- Misses        99214     248276     +149062     
- Partials      20195      24429       +4234     
Flag Coverage Δ
integration 37.9280% <76.0479%> (?)
unit 72.4993% <11.9760%> (-0.0090%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0435% <78.4431%> (+17.4828%) ⬆️

Signed-off-by: Jianjun Liao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving visualization of BR
1 participant