-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external_storage: implement locking #56597
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56597 +/- ##
=================================================
- Coverage 74.8131% 57.6708% -17.1424%
=================================================
Files 1570 1832 +262
Lines 364718 686956 +322238
=================================================
+ Hits 272857 396173 +123316
- Misses 72124 264845 +192721
- Partials 19737 25938 +6201
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@YuJuncen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| Verify() → **OK** | | | ||
| | Write("LOCK_Bob", "") → **OK** | | ||
| Write("LOCK_Alice", "") → **OK** | | | ||
| | Verify() → **Failed! "LOCK_Alice" exists** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When contention is high no one can commit? It doesn't scale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a randomized back off algorithm can help. Anyway this is like some sort of optimistic lock, hence not pretty effective in the scenario that tons of clients racing for one lock...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK if there will not be too many clients in the use case
What problem does this PR solve?
Issue Number: close #56523
Problem Summary:
See the issue. We need a safer method to lock the external storage.
What changed and how does it work?
This PR implemented the "put and verify" txn, also a document was provided.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.