Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: separate reader and mutator #56376

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

meta.NewMeta is meaningless, we abstract a meta Reader and separate it out of Mutator

Check List

Tests

  • Unit test. existing ut should cover it, we mostly only rename structs
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

tiprow bot commented Sep 27, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -936,37 +936,6 @@ func BuildBackupSchemas(
return nil
}

// BuildFullSchema builds a full backup schemas for databases and tables.
func BuildFullSchema(storage kv.Storage, backupTS uint64, fn func(dbInfo *model.DBInfo, tableInfo *model.TableInfo)) error {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless now

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2024
@D3Hunter D3Hunter mentioned this pull request Sep 27, 2024
54 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 97.00272% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.1174%. Comparing base (f7eba7e) to head (0cf9229).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56376        +/-   ##
================================================
+ Coverage   73.3853%   76.1174%   +2.7320%     
================================================
  Files          1622       1645        +23     
  Lines        447194     455366      +8172     
================================================
+ Hits         328175     346613     +18438     
+ Misses        98918      87147     -11771     
- Partials      20101      21606      +1505     
Flag Coverage Δ
integration 51.9311% <78.4741%> (?)
unit 72.5441% <94.5504%> (+0.0745%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0417% <83.3333%> (+17.5319%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2024
Copy link

ti-chi-bot bot commented Sep 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-27 09:15:24.793680786 +0000 UTC m=+680.213893782: ☑️ agreed by tangenta.
  • 2024-09-27 09:20:27.366958555 +0000 UTC m=+982.787171565: ☑️ agreed by lcwangchao.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 27, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Benjamin2037
Copy link
Collaborator

/retest

Copy link

tiprow bot commented Sep 27, 2024

@Benjamin2037: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, lance6716, lcwangchao, tangenta, tiancaiamao, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit b427e33 into pingcap:master Sep 27, 2024
22 of 27 checks passed
@D3Hunter D3Hunter deleted the rename-meta branch September 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants