ddl: refactor job args for set/update tiflash-replica and alter-table-placement ddl #56241

joccau · 2024-09-23T14:28:41Z

What problem does this PR solve?

Issue Number: Ref #53930
Ref #54436

Problem Summary:

What changed and how does it work?

Refactor the job args for follow ddl type:

ActionAlterTablePlacement
ActionUpdateTiFlashReplicaStatus
ActionSetTiFlashReplica

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: joccau <[email protected]>

codecov · 2024-09-23T14:40:58Z

Codecov Report

Attention: Patch coverage is 86.07595% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.2372%. Comparing base (7c88876) to head (acfb412).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56241        +/-   ##
================================================
+ Coverage   73.3294%   76.2372%   +2.9077%     
================================================
  Files          1619       1641        +22     
  Lines        446470     455586      +9116     
================================================
+ Hits         327394     347326     +19932     
+ Misses        99020      86776     -12244     
- Partials      20056      21484      +1428

Flag	Coverage Δ
integration	`52.1517% <16.4557%> (?)`
unit	`72.6033% <86.0759%> (+0.0867%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.0988% <ø> (+18.0692%)`	⬆️

Signed-off-by: joccau <[email protected]>

joccau · 2024-09-24T15:49:16Z

/test pull-br-integration-test

tiprow · 2024-09-24T15:49:22Z

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddl
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/ddl/executor.go

pkg/meta/model/job_args.go

Signed-off-by: joccau <[email protected]>

joccau · 2024-09-25T05:27:31Z

/retest

Co-authored-by: D3Hunter <[email protected]>

ti-chi-bot · 2024-09-25T07:52:27Z

@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lance6716

rest lgtm

lance6716 · 2024-09-25T07:53:48Z

pkg/ddl/executor.go

@@ -565,20 +565,21 @@ func (e *executor) ModifySchemaSetTiFlashReplica(sctx sessionctx.Context, stmt *
 		}

 		job := &model.Job{


maybe in future, we can have a newJob function to avoid the job constructor changes need to be edit at many places

Good idea～

lance6716 · 2024-09-25T07:55:55Z

pkg/ddl/executor.go

-			if ref == nil {
-				continue
-			}
-			involvingSchemaInfo = append(involvingSchemaInfo, model.InvolvingSchemaInfo{


where does it move to?

Because the ActionAlterTablePlacement ddl is not belong to multiSchemaChange. It's useless.

joccau · 2024-09-25T08:15:33Z

/test pull-br-integration-test

tiprow · 2024-09-25T08:15:40Z

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddl
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lance6716 · 2024-09-25T08:20:14Z

/approve

lance6716 · 2024-09-25T08:20:24Z

/lgtm

ti-chi-bot · 2024-09-25T08:20:33Z

[LGTM Timeline notifier]

Timeline:

2024-09-25 07:25:52.450117255 +0000 UTC m=+1637222.190541193: ☑️ agreed by D3Hunter.
2024-09-25 08:20:32.933811517 +0000 UTC m=+1640502.674235457: ☑️ agreed by lance6716.

ti-chi-bot · 2024-09-25T08:20:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, joechenrh, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/ddl/OWNERS~~ [D3Hunter,lance6716]
~~pkg/meta/OWNERS~~ [D3Hunter,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: joccau <[email protected]>

joccau · 2024-09-25T14:45:55Z

/retest

joccau · 2024-09-26T00:00:51Z

/retest

D3Hunter · 2024-09-26T02:20:04Z

/retest

D3Hunter · 2024-09-26T03:18:54Z

/retest

D3Hunter · 2024-09-26T05:14:18Z

/retest

joccau added 2 commits September 22, 2024 22:50

refactor the type of AlterTablePlacement

8e28abb

Signed-off-by: joccau <[email protected]>

Merge remote-tracking branch 'origin/master' into ddl-in-multiSchema

7ea59da

joccau changed the title ~~[wip]ddl: refactor job args for~~ [wip]ddl: refactor job args for AlterTablePlacement Sep 23, 2024

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Sep 23, 2024

refactor the job args for AlterTablePlacement

9b29e9c

Signed-off-by: joccau <[email protected]>

D3Hunter mentioned this pull request Sep 23, 2024

ddl code refactor/optimize #54436

Open

54 tasks

joccau force-pushed the ddl-in-multiSchema branch from 5b4f329 to 9b29e9c Compare September 24, 2024 03:50

joccau added 3 commits September 24, 2024 12:15

refactor the job args for Set Tiflash replica ddl

c5ec72f

Signed-off-by: joccau <[email protected]>

refactor the job args for updating TiFlash replica status ddl

7b71ec2

Signed-off-by: joccau <[email protected]>

Merge remote-tracking branch 'origin/master' into ddl-in-multiSchema

4ffc7c4

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2024

joccau changed the title ~~[wip]ddl: refactor job args for AlterTablePlacement~~ [wip]ddl: refactor job args for set-tiflash-replica/update-tiflash-replica and alter-table-placement ddl. Sep 24, 2024

joccau changed the title ~~[wip]ddl: refactor job args for set-tiflash-replica/update-tiflash-replica and alter-table-placement ddl.~~ ddl: refactor job args for set-tiflash-replica/update-tiflash-replica and alter-table-placement ddl. Sep 24, 2024

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024

D3Hunter reviewed Sep 25, 2024

View reviewed changes

pkg/ddl/executor.go Outdated Show resolved Hide resolved

pkg/meta/model/job_args.go Show resolved Hide resolved

pkg/meta/model/job_args.go Outdated Show resolved Hide resolved

pkg/meta/model/job_args.go Outdated Show resolved Hide resolved

D3Hunter changed the title ~~ddl: refactor job args for set-tiflash-replica/update-tiflash-replica and alter-table-placement ddl.~~ ddl: refactor job args for set/update tiflash-replica and alter-table-placement ddl Sep 25, 2024

add json tag in the struct of job args.

1f7f64c

Signed-off-by: joccau <[email protected]>

joccau and others added 2 commits September 25, 2024 15:25

Update pkg/meta/model/job_args.go

a9838cc

Co-authored-by: D3Hunter <[email protected]>

Update pkg/ddl/executor.go

6e21e2b

Co-authored-by: D3Hunter <[email protected]>

D3Hunter approved these changes Sep 25, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024

joccau requested a review from lance6716 September 25, 2024 07:35

joechenrh approved these changes Sep 25, 2024

View reviewed changes

lance6716 reviewed Sep 25, 2024

View reviewed changes

joccau requested a review from lance6716 September 25, 2024 08:09

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024

joccau added 2 commits September 25, 2024 21:24

Merge remote-tracking branch 'origin/master' into ddl-in-multiSchema

c4a436a

make bazel

d44b131

Signed-off-by: joccau <[email protected]>

D3Hunter added 2 commits September 26, 2024 00:55

Merge remote-tracking branch 'upstream/master' into ddl-in-multiSchema

386d42a

lint

0e83466

Merge remote-tracking branch 'upstream/master' into ddl-in-multiSchema

acfb412

ti-chi-bot bot merged commit 9dff38b into pingcap:master Sep 26, 2024
25 checks passed

D3Hunter mentioned this pull request Oct 14, 2024

improve the usability of DDL Job.Args #53930

Open

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: refactor job args for set/update tiflash-replica and alter-table-placement ddl #56241

ddl: refactor job args for set/update tiflash-replica and alter-table-placement ddl #56241

joccau commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading

joccau commented Sep 24, 2024

tiprow bot commented Sep 24, 2024

joccau commented Sep 25, 2024

ti-chi-bot bot commented Sep 25, 2024

lance6716 left a comment

lance6716 Sep 25, 2024

joccau Sep 25, 2024

lance6716 Sep 25, 2024

joccau Sep 25, 2024

joccau commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lance6716 commented Sep 25, 2024

lance6716 commented Sep 25, 2024

ti-chi-bot bot commented Sep 25, 2024

ti-chi-bot bot commented Sep 25, 2024

joccau commented Sep 25, 2024

joccau commented Sep 26, 2024

D3Hunter commented Sep 26, 2024

D3Hunter commented Sep 26, 2024

D3Hunter commented Sep 26, 2024

		@@ -565,20 +565,21 @@ func (e executor) ModifySchemaSetTiFlashReplica(sctx sessionctx.Context, stmt
		}

		job := &model.Job{

ddl: refactor job args for set/update tiflash-replica and alter-table-placement ddl #56241

ddl: refactor job args for set/update tiflash-replica and alter-table-placement ddl #56241

Conversation

joccau commented Sep 23, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

codecov bot commented Sep 23, 2024 • edited Loading

Codecov Report

joccau commented Sep 24, 2024

tiprow bot commented Sep 24, 2024

joccau commented Sep 25, 2024

ti-chi-bot bot commented Sep 25, 2024

lance6716 left a comment

Choose a reason for hiding this comment

lance6716 Sep 25, 2024

Choose a reason for hiding this comment

joccau Sep 25, 2024

Choose a reason for hiding this comment

lance6716 Sep 25, 2024

Choose a reason for hiding this comment

joccau Sep 25, 2024

Choose a reason for hiding this comment

joccau commented Sep 25, 2024

tiprow bot commented Sep 25, 2024

lance6716 commented Sep 25, 2024

lance6716 commented Sep 25, 2024

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Sep 25, 2024

joccau commented Sep 25, 2024

joccau commented Sep 26, 2024

D3Hunter commented Sep 26, 2024

D3Hunter commented Sep 26, 2024

D3Hunter commented Sep 26, 2024

joccau commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading