ddl: refactor job args for alter sequence/auto-id-cache/shard-rowid/cache/ttl related ddl job.

[joccau]

What problem does this PR solve?

Issue Number: Ref #53930
Ref #54436

Problem Summary:

What changed and how does it work?

Refactor the job args for follow ddl types:

• ActionAlterSequence
• ActionModifyTableAutoIDCache
• ActionShardRowID
• ActionAlterCacheTable
• ActionAlterNoCacheTable
• ActionAlterTTLInfo
• ActionAlterTTLRemove

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 15 lines in your changes missing coverage. Please review.

Project coverage is 76.0641%. Comparing base (bf455f5) to head (b9410a9).
Report is 3 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #56206        +/-   ##
================================================
+ Coverage   73.4156%   76.0641%   +2.6484%     
================================================
  Files          1605       1627        +22     
  Lines        445006     453332      +8326     
================================================
+ Hits         326704     344823     +18119     
+ Misses        98251      87056     -11195     
- Partials      20051      21453      +1402     

Flag	Coverage Δ
integration	51.7130% <53.3333%> (?)
unit	72.5196% <78.0952%> (+0.0118%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <ø> (ø)
parser	∅ <ø> (∅)
br	63.0335% <ø> (+17.0025%)	⬆️

[joccau]

/retest

[joccau]

/test unit-test

[tiprow]

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

rest lgtm

[D3Hunter]

/hold

TestIndexMergePanic failed, the panic is expected, but it timed out

[2024/09/24 08:33:36.091 +00:00] [ERROR] [misc.go:93] ["panic in the recoverable goroutine"] [r="failpoint panic: github.com/pingcap/tidb/pkg/executor/testIndexMergePanicPartialIndexWorker"] ["stack trace"="github.com/pingcap/tidb/pkg/util.WithRecovery.func1\n\tpkg/util/misc.go:95\nruntime.gopanic\n\tGOROOT/src/runtime/panic.go:920\ngithub.com/pingcap/failpoint.actPanic\n\texternal/com_github_pingcap_failpoint/terms.go:344\ngithub.com/pingcap/failpoint.(*term).do\n\texternal/com_github_pingcap_failpoint/terms.go:311\ngithub.com/pingcap/failpoint.(*terms).eval\n\texternal/com_github_pingcap_failpoint/terms.go:116\ngithub.com/pingcap/failpoint.(*Failpoint).Eval\n\texternal/com_github_pingcap_failpoint/failpoint.go:129\ngithub.com/pingcap/failpoint.(*Failpoints).Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:231\ngithub.com/pingcap/failpoint.Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:311\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1.1\n\tpkg/executor/index_merge_reader.go:362\ngithub.com/pingcap/tidb/pkg/util.WithRecovery\n\tpkg/util/misc.go:98\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1\n\tpkg/executor/index_merge_reader.go:360"] [stack="github.com/pingcap/tidb/pkg/util.WithRecovery.func1\n\tpkg/util/misc.go:93\nruntime.gopanic\n\tGOROOT/src/runtime/panic.go:920\ngithub.com/pingcap/failpoint.actPanic\n\texternal/com_github_pingcap_failpoint/terms.go:344\ngithub.com/pingcap/failpoint.(*term).do\n\texternal/com_github_pingcap_failpoint/terms.go:311\ngithub.com/pingcap/failpoint.(*terms).eval\n\texternal/com_github_pingcap_failpoint/terms.go:116\ngithub.com/pingcap/failpoint.(*Failpoint).Eval\n\texternal/com_github_pingcap_failpoint/failpoint.go:129\ngithub.com/pingcap/failpoint.(*Failpoints).Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:231\ngithub.com/pingcap/failpoint.Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:311\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1.1\n\tpkg/executor/index_merge_reader.go:362\ngithub.com/pingcap/tidb/pkg/util.WithRecovery\n\tpkg/util/misc.go:98\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1\n\tpkg/executor/index_merge_reader.go:360"]

[D3Hunter]

/unhold

seems not related to this pr

/hold

TestIndexMergePanic failed, the panic is expected, but it timed out

[2024/09/24 08:33:36.091 +00:00] [ERROR] [misc.go:93] ["panic in the recoverable goroutine"] [r="failpoint panic: github.com/pingcap/tidb/pkg/executor/testIndexMergePanicPartialIndexWorker"] ["stack trace"="github.com/pingcap/tidb/pkg/util.WithRecovery.func1\n\tpkg/util/misc.go:95\nruntime.gopanic\n\tGOROOT/src/runtime/panic.go:920\ngithub.com/pingcap/failpoint.actPanic\n\texternal/com_github_pingcap_failpoint/terms.go:344\ngithub.com/pingcap/failpoint.(*term).do\n\texternal/com_github_pingcap_failpoint/terms.go:311\ngithub.com/pingcap/failpoint.(*terms).eval\n\texternal/com_github_pingcap_failpoint/terms.go:116\ngithub.com/pingcap/failpoint.(*Failpoint).Eval\n\texternal/com_github_pingcap_failpoint/failpoint.go:129\ngithub.com/pingcap/failpoint.(*Failpoints).Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:231\ngithub.com/pingcap/failpoint.Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:311\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1.1\n\tpkg/executor/index_merge_reader.go:362\ngithub.com/pingcap/tidb/pkg/util.WithRecovery\n\tpkg/util/misc.go:98\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1\n\tpkg/executor/index_merge_reader.go:360"] [stack="github.com/pingcap/tidb/pkg/util.WithRecovery.func1\n\tpkg/util/misc.go:93\nruntime.gopanic\n\tGOROOT/src/runtime/panic.go:920\ngithub.com/pingcap/failpoint.actPanic\n\texternal/com_github_pingcap_failpoint/terms.go:344\ngithub.com/pingcap/failpoint.(*term).do\n\texternal/com_github_pingcap_failpoint/terms.go:311\ngithub.com/pingcap/failpoint.(*terms).eval\n\texternal/com_github_pingcap_failpoint/terms.go:116\ngithub.com/pingcap/failpoint.(*Failpoint).Eval\n\texternal/com_github_pingcap_failpoint/failpoint.go:129\ngithub.com/pingcap/failpoint.(*Failpoints).Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:231\ngithub.com/pingcap/failpoint.Eval\n\texternal/com_github_pingcap_failpoint/failpoints.go:311\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1.1\n\tpkg/executor/index_merge_reader.go:362\ngithub.com/pingcap/tidb/pkg/util.WithRecovery\n\tpkg/util/misc.go:98\ngithub.com/pingcap/tidb/pkg/executor.(*IndexMergeReaderExecutor).startPartialIndexWorker.func1\n\tpkg/executor/index_merge_reader.go:360"]

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [D3Hunter,tangenta]
• pkg/meta/OWNERS [D3Hunter,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-24 07:08:37.185501752 +0000 UTC m=+1549786.925925686: ☑️ agreed by D3Hunter.
• 2024-09-25 09:08:59.667468295 +0000 UTC m=+1643409.407892231: ☑️ agreed by tangenta.