ddl: decouple executor part out from `ddl` #54858

D3Hunter · 2024-07-24T04:48:50Z

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

decouple executor part out from ddl, as this PR is quite large, some part is still coupled, will do it in next pr
this pr is large mostly due to changes of rename such as from (d *ddl) to (e *executor), and callsite of domain.DDL -> domain.DDLExecutor

Check List

Tests

Unit test, this PR only fix existing tests, no need to add more as this PR only re-structure existing code
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-07-24T04:49:11Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-07-24T06:01:58Z

pkg/ddl/executor_test.go

 )

+func TestGetDDLJobs(t *testing.T) {


moved from prev ddl_api_test.go

D3Hunter · 2024-07-24T06:10:59Z

pkg/ddl/ddl_api_test.go

move to executor_test.go

D3Hunter · 2024-07-24T06:19:29Z

pkg/ddl/executor.go

+}
+
+// TODO remove it later.
+func (e *executor) callHookOnChanged(job *model.Job, err error) error {


duplicate with what's in ddl, will change it later, this pr is very large now.

codecov · 2024-07-24T06:35:06Z

Codecov Report

Attention: Patch coverage is 80.69307% with 39 lines in your changes missing coverage. Please review.

Project coverage is 57.0257%. Comparing base (3148c80) to head (466d4e3).
Report is 3 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54858         +/-   ##
=================================================
- Coverage   74.7336%   57.0257%   -17.7079%     
=================================================
  Files          1557       1682        +125     
  Lines        363772     619778     +256006     
=================================================
+ Hits         271860     353433      +81573     
- Misses        72152     242087     +169935     
- Partials      19760      24258       +4498

Flag	Coverage Δ
integration	`38.4674% <53.9604%> (?)`
unit	`72.1872% <79.7029%> (-1.4513%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9656% <ø> (-2.2339%)`	⬇️
parser	`∅ <ø> (∅)`
br	`62.9989% <100.0000%> (+15.3655%)`	⬆️

ti-chi-bot · 2024-07-24T07:57:06Z

[LGTM Timeline notifier]

Timeline:

2024-07-24 07:31:27.984136039 +0000 UTC m=+1030309.975077509: ☑️ agreed by lance6716.
2024-07-24 07:57:05.41568261 +0000 UTC m=+1031847.406624080: ☑️ agreed by tangenta.

ti-chi-bot · 2024-07-24T08:05:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, lance6716, Leavrth, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,Leavrth,lance6716,tangenta]
~~br/OWNERS~~ [Leavrth]
~~pkg/ddl/OWNERS~~ [tangenta]
~~pkg/domain/OWNERS~~ [lance6716,tangenta]
~~pkg/infoschema/OWNERS~~ [tangenta]
~~pkg/owner/OWNERS~~ [tangenta]
~~pkg/planner/OWNERS~~ [AilinKid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2024-07-24T10:21:29Z

/retest

tiprow · 2024-07-24T10:21:51Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-07-24T12:17:42Z

/retest

tiprow · 2024-07-24T12:18:11Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2024-07-24T12:27:37Z

/retest

tiprow · 2024-07-24T12:27:58Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter added 2 commits July 23, 2024 20:24

change

c22bd9b

change

a93c3a0

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 24, 2024

Merge remote-tracking branch 'upstream/master' into decouple-ddl-execute

7b83303

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024

change

e635a70

D3Hunter commented Jul 24, 2024

View reviewed changes

pkg/ddl/executor_test.go

)

func TestGetDDLJobs(t *testing.T) {

Copy link

Contributor Author

D3Hunter Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from prev ddl_api_test.go

change

5ace612

D3Hunter commented Jul 24, 2024

View reviewed changes

pkg/ddl/ddl_api_test.go Outdated

Copy link

Contributor Author

D3Hunter Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to executor_test.go

D3Hunter commented Jul 24, 2024

View reviewed changes

D3Hunter mentioned this pull request Jul 24, 2024

ddl code refactor/optimize #54436

Open

54 tasks

D3Hunter requested a review from lance6716 July 24, 2024 07:13

lance6716 approved these changes Jul 24, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 24, 2024

tangenta approved these changes Jul 24, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 24, 2024

Leavrth approved these changes Jul 24, 2024

View reviewed changes

AilinKid approved these changes Jul 24, 2024

View reviewed changes

ti-chi-bot bot added the approved label Jul 24, 2024

Merge remote-tracking branch 'upstream/master' into decouple-ddl-execute

91cd044

ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 24, 2024

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024

Merge remote-tracking branch 'upstream/master' into decouple-ddl-execute

466d4e3

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2024

ti-chi-bot bot merged commit 8f98b4e into pingcap:master Jul 24, 2024
22 checks passed

D3Hunter deleted the decouple-ddl-execute branch July 24, 2024 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: decouple executor part out from `ddl` #54858

ddl: decouple executor part out from `ddl` #54858

D3Hunter commented Jul 24, 2024 •

edited

Loading

tiprow bot commented Jul 24, 2024

D3Hunter Jul 24, 2024

D3Hunter Jul 24, 2024

D3Hunter Jul 24, 2024

codecov bot commented Jul 24, 2024 •

edited

Loading

ti-chi-bot bot commented Jul 24, 2024

ti-chi-bot bot commented Jul 24, 2024

D3Hunter commented Jul 24, 2024

tiprow bot commented Jul 24, 2024

D3Hunter commented Jul 24, 2024

tiprow bot commented Jul 24, 2024

D3Hunter commented Jul 24, 2024

tiprow bot commented Jul 24, 2024

ddl: decouple executor part out from ddl #54858

ddl: decouple executor part out from ddl #54858

Conversation

D3Hunter commented Jul 24, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Jul 24, 2024

D3Hunter Jul 24, 2024

Choose a reason for hiding this comment

D3Hunter Jul 24, 2024

Choose a reason for hiding this comment

D3Hunter Jul 24, 2024

Choose a reason for hiding this comment

codecov bot commented Jul 24, 2024 • edited Loading

Codecov Report

ti-chi-bot bot commented Jul 24, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Jul 24, 2024

D3Hunter commented Jul 24, 2024

tiprow bot commented Jul 24, 2024

D3Hunter commented Jul 24, 2024

tiprow bot commented Jul 24, 2024

D3Hunter commented Jul 24, 2024

tiprow bot commented Jul 24, 2024

ddl: decouple executor part out from `ddl` #54858

ddl: decouple executor part out from `ddl` #54858

D3Hunter commented Jul 24, 2024 •

edited

Loading

codecov bot commented Jul 24, 2024 •

edited

Loading