ddl/ingest: refactor checkpoint manager

[tangenta]

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

• Move FinishAndUnregisterEngines() out of AddIndexIngestPipeline. Thus, we put Register() and Unregister() to the same code level.
• Add an option to FinishAndUnregisterEngines() to control the behavior of "clean up local path data" and "check duplicated entry" in different scenarios.
• Refine logs.
• Remove BackendCtx.SetDone() and BackendCtx.Done(), use adjustStartKey to skip imported data.
• Simplify checkpoint manager logic. Now we use importedKeyLowWatermark to determine startKey in next round(see getCheckpointReorgHandle).
• Add integration tests for checkpoint manager.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 73.91304% with 30 lines in your changes missing coverage. Please review.

Project coverage is 56.5653%. Comparing base (e53bfc4) to head (7b3bcb9).
Report is 34 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54747         +/-   ##
=================================================
- Coverage   72.7192%   56.5653%   -16.1540%     
=================================================
  Files          1555       1681        +126     
  Lines        437547     621807     +184260     
=================================================
+ Hits         318181     351727      +33546     
- Misses        99734     246413     +146679     
- Partials      19632      23667       +4035     

Flag	Coverage Δ
integration	37.6283% <71.3043%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	52.1440% <ø> (+6.2960%)	⬆️

[tangenta]

/hold

[tangenta]

/unhold

[tangenta]

Will be registered in runAddIndexInLocalIngestMode.

[lance6716]

7 / 17 files viewed

[D3Hunter]

rest lgtm

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-24 03:51:13.931262748 +0000 UTC m=+1017095.922204217: ☑️ agreed by D3Hunter.
• 2024-07-24 05:29:35.919453023 +0000 UTC m=+1022997.910394494: ☑️ agreed by lance6716.

[tangenta]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,lance6716,tangenta]
• pkg/ddl/OWNERS [tangenta]
• pkg/parser/OWNERS [D3Hunter,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tangenta]

/retest

[tiprow]

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.