-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: refine the runaway code and fix typos #54435
Conversation
Signed-off-by: JmPotato <[email protected]>
/cc @lance6716 @nolouch @HuSharp PTAL, thx. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54435 +/- ##
=================================================
- Coverage 74.7851% 55.8517% -18.9334%
=================================================
Files 1536 1652 +116
Lines 361822 603698 +241876
=================================================
+ Hits 270589 337176 +66587
- Misses 71592 243310 +171718
- Partials 19641 23212 +3571
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: ref #54434.
What changed and how does it work?
Fix some typos and refine the runaway-related code.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.