Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: refine the runaway code and fix typos #54435

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jul 4, 2024

What problem does this PR solve?

Issue Number: ref #54434.

What changed and how does it work?

Fix some typos and refine the runaway-related code.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Jul 4, 2024

/cc @lance6716 @nolouch @HuSharp

PTAL, thx.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2024
Copy link

ti-chi-bot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2024
Copy link

ti-chi-bot bot commented Jul 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-04 06:56:18.838526772 +0000 UTC m=+1480305.324015603: ☑️ agreed by lance6716.
  • 2024-07-04 07:02:48.709076055 +0000 UTC m=+1480695.194564888: ☑️ agreed by nolouch.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.8517%. Comparing base (be16d49) to head (6467cc8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54435         +/-   ##
=================================================
- Coverage   74.7851%   55.8517%   -18.9334%     
=================================================
  Files          1536       1652        +116     
  Lines        361822     603698     +241876     
=================================================
+ Hits         270589     337176      +66587     
- Misses        71592     243310     +171718     
- Partials      19641      23212       +3571     
Flag Coverage Δ
integration 22.0561% <52.6315%> (?)
unit 71.8293% <89.4736%> (-1.8683%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 52.6285% <ø> (+4.7131%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 6421f86 into pingcap:master Jul 4, 2024
23 checks passed
@JmPotato JmPotato deleted the refine_runaway branch July 4, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants