Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TidbCluster: disable evict leader for TiKV EBS modification (#5826) #5829

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5826

What problem does this PR solve?

evict leader for TiKV may take a long time, and the performance drop without leader-eviction is very low.

So we decide to disable this leader-eviction behavior for TiKV EBS modification.

NOTE: do not upgrade TiDB Operator when some leader-eviction (with EBS modification, but do not include EBS size modification, ref #5101) is happening as after this PR no "remove evict-leader-scheduler" will be performed then some evict-leader-scheduler may be kept.

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

disable leader-eviction for TiKV EBS modification

Copy link
Contributor

ti-chi-bot bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge October 31, 2024 11:50
@csuzhangxc csuzhangxc merged commit fcbf256 into pingcap:release-1.5 Oct 31, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants