Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-service: add pause and resume api for http-service #5367

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

KanShiori
Copy link
Collaborator

@KanShiori KanShiori commented Nov 2, 2023

What problem does this PR solve?

add pause and resume api for http-service

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  1. Deploy a new cluster named 'shiori'.
  2. Pause the cluster via http-service, and check the tc.
apiVersion: pingcap.com/v1alpha1
kind: TidbCluster
metadata:
  creationTimestamp: "2023-11-02T08:44:43Z"
  generation: 2
  name: db
  namespace: shiori
  resourceVersion: "6729"
  uid: 981badd9-9b5e-454b-84a7-ee81bab71fa3
spec:
  # ...
  suspendAction:
    suspendStatefulSet: true
  1. Resume the cluster via http-service, and check the tc.
apiVersion: pingcap.com/v1alpha1
kind: TidbCluster
metadata:
  creationTimestamp: "2023-11-02T08:44:43Z"
  generation: 3
  name: db
  namespace: shiori
  resourceVersion: "7354"
  uid: 981badd9-9b5e-454b-84a7-ee81bab71fa3
spec:
# ...
  suspendAction: {}
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kanshiori. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KanShiori KanShiori changed the title http-server: add pause and resume for http-service http-service: add pause and resume api for http-service Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #5367 (73abff7) into master (e77905f) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5367      +/-   ##
==========================================
+ Coverage   61.58%   61.59%   +0.01%     
==========================================
  Files         228      228              
  Lines       28866    28866              
==========================================
+ Hits        17776    17780       +4     
+ Misses       9345     9342       -3     
+ Partials     1745     1744       -1     
Flag Coverage Δ
unittest 61.59% <ø> (+0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit 0cd81d1 into pingcap:master Nov 6, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants