Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: modify time complete of restore status (#5248) #5260

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5248

What problem does this PR solve?

Make sure time complete is valid for restore with volume-snapshot mode.

Closes #5239

What is changed and how does it work?

Before this change, the timeStarted and timeCompleted in restore status is the time of data restore phase. We change timeStarted to start time of volume restore phase and timeCompleted to the time of restore complete.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test

image

  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ehco1996 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from KanShiori and shonge August 22, 2023 07:50
@codecov-commenter
Copy link

Codecov Report

Merging #5260 (f463992) into release-1.5 (c89b9af) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5260      +/-   ##
===============================================
+ Coverage        57.26%   57.27%   +0.01%     
===============================================
  Files              249      249              
  Lines            29900    29901       +1     
===============================================
+ Hits             17121    17125       +4     
+ Misses           11119    11117       -2     
+ Partials          1660     1659       -1     
Flag Coverage Δ
unittest 57.27% <0.00%> (+0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit 99eba51 into pingcap:release-1.5 Aug 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants