Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add missing tiproxy label #5259

Merged
merged 2 commits into from
Jan 3, 2024
Merged

*: add missing tiproxy label #5259

merged 2 commits into from
Jan 3, 2024

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 21, 2023

Reverts #5244

@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge August 21, 2023 07:53
@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc74dc1) 61.38% compared to head (4284326) 61.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5259      +/-   ##
==========================================
+ Coverage   61.38%   61.39%   +0.01%     
==========================================
  Files         234      234              
  Lines       29930    29930              
==========================================
+ Hits        18373    18377       +4     
+ Misses       9717     9715       -2     
+ Partials     1840     1838       -2     
Flag Coverage Δ
unittest 61.39% <ø> (+0.01%) ⬆️

@xhebox xhebox changed the title Revert "fix: revert 'add missing tiproxy label'" *: add missing tiproxy label Jan 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-03 11:14:15.83437739 +0000 UTC m=+2255546.871604317: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 3, 2024
@csuzhangxc csuzhangxc merged commit f1354d4 into master Jan 3, 2024
5 of 6 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@csuzhangxc csuzhangxc deleted the revert-5244-master branch January 3, 2024 11:15
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request could not be created: failed to create pull request against pingcap/tidb-operator#release-1.5 from head ti-chi-bot:cherry-pick-5259-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-1.5 and ti-chi-bot:cherry-pick-5259-to-release-1.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants