Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow porting labels when initiating backup/restore member (#5241) #5247

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5241

What problem does this PR solve?

What is changed and how does it work?

iam role cannot be used during backup process

Code changes

  • Has Go code change
  • Has CI related scripts change
    allow porting labels when initiating backup/restore member

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Reviewers: @WangLe1321 @BornChanger

@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-5241-to-release-1.5 branch from cab10f5 to caab580 Compare August 16, 2023 07:43
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #5247 (caab580) into release-1.5 (4d31255) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5247      +/-   ##
===============================================
- Coverage        57.75%   57.73%   -0.03%     
===============================================
  Files              249      249              
  Lines            29574    29575       +1     
===============================================
- Hits             17081    17074       -7     
- Misses           10838    10843       +5     
- Partials          1655     1658       +3     
Flag Coverage Δ
unittest 57.73% <100.00%> (-0.03%) ⬇️

@BornChanger BornChanger reopened this Aug 18, 2023
@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-18 08:29:49.153724699 +0000 UTC m=+878953.702740670: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BornChanger,WangLe1321]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit c2efa7e into pingcap:release-1.5 Aug 18, 2023
10 of 18 checks passed
@nkg- nkg- mentioned this pull request Oct 23, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants