Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: check status of global nodes before doing data recovery #5243

Closed
wants to merge 1 commit into from

Conversation

BornChanger
Copy link
Contributor

What problem does this PR solve?

Close #5242

What is changed and how does it work?

For TiDB cluster deployed across K8S, there could be more than one TC Clusters. EBS data restore should start until all TiKV Nodes and PD nodes are ready.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge August 14, 2023 13:03
@ti-chi-bot ti-chi-bot bot added the size/L label Aug 14, 2023
@ti-chi-bot ti-chi-bot bot added size/S and removed size/L labels Aug 14, 2023
@BornChanger BornChanger changed the title ebs br: Check global nodes ebs br: check status of global nodes before doing data recovery Aug 14, 2023
@BornChanger
Copy link
Contributor Author

The Tik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: restore data should be after tikv nodes are all ready
1 participant