Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: keep ports config for TiFlash 7.1.0+ to avoid restarting (#5223) #5225

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5223

What problem does this PR solve?

in #5075, we removed tcp and http ports for tiflash >= 7.1.0.

In this PR, add a tidb.pingcap.com/tiflash-710-keep-ports annotation to avoid restarting when upgrading TiDB Operator for existing TiFlash (>= 7.1.0)

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
    • deploy operator without Remove tcp and http ports for tiflash >= 7.1.0 #5075
    • create a >=v7.1.0 cluster with TiFlash
    • add annotation tidb.pingcap.com/tiflash-710-keep-ports in tc
    • upgrade operator to this PR version
    • observe no TiFlash upgrade
    • remove the annotation
    • observe TiFlash upgrade
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grovecai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #5225 (ebde003) into release-1.5 (5422562) will decrease coverage by 0.01%.
Report is 2 commits behind head on release-1.5.
The diff coverage is 85.71%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5225      +/-   ##
===============================================
- Coverage        57.73%   57.73%   -0.01%     
===============================================
  Files              249      249              
  Lines            29571    29574       +3     
===============================================
+ Hits             17074    17075       +1     
- Misses           10841    10842       +1     
- Partials          1656     1657       +1     
Flag Coverage Δ
unittest 57.73% <85.71%> (-0.01%) ⬇️

@csuzhangxc csuzhangxc merged commit 4d31255 into pingcap:release-1.5 Aug 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants