Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add label overwrite for tiproxy component val compatibility and min ready sec #5194

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jul 21, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@xhebox xhebox requested a review from csuzhangxc July 21, 2023 09:25
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #5194 (3c62e6b) into master (899409c) will decrease coverage by 0.04%.
Report is 2 commits behind head on master.
The diff coverage is 43.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5194      +/-   ##
==========================================
- Coverage   57.79%   57.76%   -0.04%     
==========================================
  Files         245      246       +1     
  Lines       29327    29476     +149     
==========================================
+ Hits        16951    17027      +76     
- Misses      10726    10794      +68     
- Partials     1650     1655       +5     
Flag Coverage Δ
unittest 57.76% <43.64%> (-0.04%) ⬇️

@xhebox xhebox changed the title fix: add label overwrite for tiproxy component val compatibility fix: add label overwrite for tiproxy component val compatibility and min ready sec Jul 26, 2023
pkg/manager/member/tiproxy_upgrader.go Outdated Show resolved Hide resolved
pkg/manager/member/tiproxy_upgrader.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 13:11:40.926288016 +0000 UTC m=+277384.868636542: ☑️ agreed by csuzhangxc.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 2, 2023
@xhebox xhebox enabled auto-merge (squash) August 2, 2023 14:01
@xhebox
Copy link
Contributor Author

xhebox commented Aug 2, 2023

/test pull-e2e-kind
/test pull-e2e-kind-basic
/test pull-e2e-kind-serial
/test pull-e2e-kind-br
/test pull-e2e-kind-across-kubernetes

@csuzhangxc csuzhangxc merged commit eea66fb into pingcap:master Aug 2, 2023
5 checks passed
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

@xhebox: The label(s) /pull-e2e-kind, /pull-e2e-kind-basic, /pull-e2e-kind-serial, /pull-e2e-kind-br, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-basic
/test pull-e2e-kind-serial
/test pull-e2e-kind-br
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants