Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add incremental backup size for volume snapshot backup #5188

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Jul 20, 2023

What problem does this PR solve?

Add incremental backup size for volume snapshot backup

Close #5187

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@WangLe1321 WangLe1321 force-pushed the feat/backup-incremental-size branch from d44469d to 4d7d04a Compare July 27, 2023 10:04
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-28 09:55:56.760534944 +0000 UTC m=+521099.355065930: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added the approved label Jul 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5188 (3ab633d) into master (87b2874) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5188      +/-   ##
==========================================
- Coverage   57.97%   57.79%   -0.18%     
==========================================
  Files         245      245              
  Lines       29240    29327      +87     
==========================================
  Hits        16951    16951              
- Misses      10641    10726      +85     
- Partials     1648     1650       +2     
Flag Coverage Δ
unittest 57.79% <0.00%> (-0.18%) ⬇️

@csuzhangxc csuzhangxc merged commit 899409c into pingcap:master Jul 28, 2023
5 checks passed
@BornChanger
Copy link
Contributor

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5211.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add incremental volume snapshot backup size
5 participants