br: add details of data plane to federation br status #5153

WangLe1321 · 2023-07-06T09:27:25Z

What problem does this PR solve?

Add status and steps of data plane restore members to the status of control plane

Add time taken to status backup and restore CR

What is changed and how does it work?

For the time taken, it's only valid for non-EBS backup & restore. Because for EBS restore, there are 2 restore phases, and the time taken means the time of 2nd restore phase.

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

restore status in control plane

status:
  commitTs: "442663722366795777"
  conditions:
  - lastTransitionTime: "2023-07-06T09:01:41Z"
    status: "True"
    type: Running
  - lastTransitionTime: "2023-07-06T09:05:00Z"
    status: "True"
    type: VolumeComplete
  - lastTransitionTime: "2023-07-06T09:07:00Z"
    status: "True"
    type: TikvComplete
  - lastTransitionTime: "2023-07-06T09:07:30Z"
    status: "True"
    type: DataComplete
  - lastTransitionTime: "2023-07-06T09:08:00Z"
    status: "True"
    type: Complete
  phase: Complete
  restores:
  - commitTs: "442663724595019777"
    k8sClusterName: dataplane-a
    phase: Complete
    restoreName: fed-restore-wl-20230706-3-dataplane-a
    tcName: restore-db-a-1
    tcNamespace: backup-wangle-a
  - commitTs: "442663722366795777"
    k8sClusterName: dataplane-b
    phase: Complete
    restoreName: fed-restore-wl-20230706-3-dataplane-b
    tcName: restore-db-b-1
    tcNamespace: backup-wangle-b
  - commitTs: "442663722366795777"
    k8sClusterName: dataplane-c
    phase: Complete
    restoreName: fed-restore-wl-20230706-3-dataplane-c
    tcName: restore-db-c-1
    tcNamespace: backup-wangle-c
  steps:
  - stepName: RestoreVolume
    timeCompleted: "2023-07-06T09:05:00Z"
    timeStarted: "2023-07-06T09:01:42Z"
    timeTaken: 3m19s
  - stepName: StartTiKV
    timeCompleted: "2023-07-06T09:07:00Z"
    timeStarted: "2023-07-06T09:05:00Z"
    timeTaken: 2m1s
  - stepName: RestoreData
    timeCompleted: "2023-07-06T09:07:30Z"
    timeStarted: "2023-07-06T09:07:00Z"
    timeTaken: 31s
  - stepName: RestartTiKV
    timeCompleted: "2023-07-06T09:08:00Z"
    timeStarted: "2023-07-06T09:07:30Z"
    timeTaken: 31s
  timeCompleted: "2023-07-06T09:08:00Z"
  timeStarted: "2023-07-06T09:01:41Z"
  timeTaken: 6m20s

Side effects

Breaking backward compatibility
Other side effects:

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Signed-off-by: WangLe1321 <[email protected]>

codecov-commenter · 2023-07-06T10:50:44Z

Codecov Report

Merging #5153 (9287ebf) into master (600b675) will increase coverage by 4.86%.
The diff coverage is 64.32%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5153      +/-   ##
==========================================
+ Coverage   57.91%   62.77%   +4.86%     
==========================================
  Files         248      252       +4     
  Lines       29194    32745    +3551     
==========================================
+ Hits        16907    20555    +3648     
+ Misses      10646    10451     -195     
- Partials     1641     1739      +98

Flag	Coverage Δ
e2e	`38.60% <0.00%> (?)`
unittest	`57.97% <70.83%> (+0.06%)`	⬆️

Signed-off-by: WangLe1321 <[email protected]>

WangLe1321 · 2023-07-06T11:07:12Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-07-06T11:07:14Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-06T11:07:14Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-06T11:17:37Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-07-06T11:17:39Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-06T11:17:40Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-07T02:25:01Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial

ti-chi-bot · 2023-07-07T02:25:03Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T02:25:03Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-07T03:37:21Z

/test pull-e2e-kind

ti-chi-bot · 2023-07-07T03:37:23Z

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T03:37:23Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-07T05:02:31Z

/test pull-e2e-kind pull-e2e-kind-serial

ti-chi-bot · 2023-07-07T05:02:33Z

@WangLe1321: The label(s) /pull-e2e-kind, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T05:02:33Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-07T06:33:51Z

/test pull-e2e-kind

ti-chi-bot · 2023-07-07T06:33:52Z

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T06:33:53Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-07T06:35:49Z

/test pull-e2e-kind-serial

ti-chi-bot · 2023-07-07T06:35:50Z

@WangLe1321: The label(s) /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T06:35:50Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-07-07T07:56:20Z

[LGTM Timeline notifier]

Timeline:

2023-07-07 07:56:20.586605412 +0000 UTC m=+59472.356944125: ☑️ agreed by BornChanger.

WangLe1321 · 2023-07-07T07:58:52Z

/test pull-e2e-kind

ti-chi-bot · 2023-07-07T07:58:54Z

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T07:58:55Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-07T08:34:32Z

/merge

ti-chi-bot · 2023-07-07T08:34:34Z

@WangLe1321: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

WangLe1321 · 2023-07-07T09:30:58Z

/test pull-e2e-kind

ti-chi-bot · 2023-07-07T09:31:00Z

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T09:31:01Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-07-07T10:05:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BornChanger,csuzhangxc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

WangLe1321 · 2023-07-07T11:13:22Z

/test pull-e2e-kind

ti-chi-bot · 2023-07-07T11:13:24Z

@WangLe1321: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T11:13:25Z

@WangLe1321: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

WangLe1321 · 2023-07-07T12:26:17Z

/cherry-pick release-1.5

ti-chi-bot · 2023-07-07T12:26:19Z

@WangLe1321: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-07T12:26:55Z

@WangLe1321: new pull request created to branch release-1.5: #5155.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Co-authored-by: WangLe1321 <[email protected]>

WangLe1321 added 6 commits July 6, 2023 12:02

br: add details of data plane to federation br status

936fb0c

Signed-off-by: WangLe1321 <[email protected]>

br: modify to use member in status to list member

982618b

Signed-off-by: WangLe1321 <[email protected]>

Merge branch 'master' into feat/br-status

eb2b971

br: fix invalid status of restore

7353034

Signed-off-by: WangLe1321 <[email protected]>

br: fix missing volume restore step

16b0cd9

Merge branch 'master' into feat/br-status

fe6ae1a

ti-chi-bot bot requested review from lichunzhu and shonge July 6, 2023 09:27

ti-chi-bot bot added the size/XXL label Jul 6, 2023

br: fix unit test

d4dde40

Signed-off-by: WangLe1321 <[email protected]>

br: fix CI error

9287ebf

Signed-off-by: WangLe1321 <[email protected]>

BornChanger approved these changes Jul 7, 2023

View reviewed changes

ti-chi-bot bot added the lgtm label Jul 7, 2023

ti-chi-bot bot added the approved label Jul 7, 2023

csuzhangxc approved these changes Jul 7, 2023

View reviewed changes

ti-chi-bot bot merged commit acbabc8 into pingcap:master Jul 7, 2023

ti-chi-bot mentioned this pull request Jul 7, 2023

br: add details of data plane to federation br status (#5153) #5155

Merged

10 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Jul 7, 2023

br: add details of data plane to federation br status (pingcap#5153)

f05e41d

csuzhangxc pushed a commit that referenced this pull request Jul 7, 2023

br: add details of data plane to federation br status (#5153) (#5155)

a5f6b50

Co-authored-by: WangLe1321 <[email protected]>

WangLe1321 mentioned this pull request Jul 10, 2023

ebs br: dataplane bk in VolumeBackupInitialized is not cleared after vbk is deleted #5080

Closed

BornChanger added the area/ebs-br label Jul 28, 2023

br: add details of data plane to federation br status #5153

br: add details of data plane to federation br status #5153

Conversation

WangLe1321 commented Jul 6, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

codecov-commenter commented Jul 6, 2023 • edited Loading

Codecov Report

WangLe1321 commented Jul 6, 2023

ti-chi-bot bot commented Jul 6, 2023

ti-chi-bot bot commented Jul 6, 2023

WangLe1321 commented Jul 6, 2023

ti-chi-bot bot commented Jul 6, 2023

ti-chi-bot bot commented Jul 6, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

[LGTM Timeline notifier]

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

WangLe1321 commented Jul 7, 2023

ti-chi-bot bot commented Jul 7, 2023

ti-chi-bot commented Jul 7, 2023

WangLe1321 commented Jul 6, 2023 •

edited

Loading

codecov-commenter commented Jul 6, 2023 •

edited

Loading