Fix TidbDashboard baseImage parsing fault (#5014) #5124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5014
Fix wrong baseImage version adapt for image tag while the repo has specified a unique port with ':'.
What problem does this PR solve?
Fix the bug that baseImage auto version adapt can be executed unexpected while the repo has specified a unique port with ':'.
e.g.
If baseImage = example.registry.com:30000/foo/pingcap/tidb-dashboard:vx.y.z, the final image will be "example.registry.com:vx.y.z".
What is changed and how does it work?
Judge whether there were '' after the last ':'. If there is one, it is not a ':' for the image tag.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.