Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TidbDashboard baseImage parsing fault (#5014) #5124

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5014

Fix wrong baseImage version adapt for image tag while the repo has specified a unique port with ':'.

What problem does this PR solve?

Fix the bug that baseImage auto version adapt can be executed unexpected while the repo has specified a unique port with ':'.

e.g.
If baseImage = example.registry.com:30000/foo/pingcap/tidb-dashboard:vx.y.z, the final image will be "example.registry.com:vx.y.z".

What is changed and how does it work?

Judge whether there were '' after the last ':'. If there is one, it is not a ':' for the image tag.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fix TidbDashboard baseImage parsing fault.

linkinghack and others added 3 commits July 3, 2023 02:55
…sion adapt for image tag while the repo has specified a unique port with ':'.

Signed-off-by: Liu Lei <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign charleszheng44 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge July 3, 2023 02:55
@ti-chi-bot ti-chi-bot bot added the size/M label Jul 3, 2023
@csuzhangxc csuzhangxc merged commit 1a3e4b9 into pingcap:release-1.5 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants