Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix renaming pvc when there are multiple volumes in tikv pod (#4951) #5112

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4951

What problem does this PR solve?

Fix the bug that TiKV pods crash when execute EBS restore to restore TiKV with multiple volumes for the reason that we renamed pvc of TiKV by mistake.

Closes #4950

What is changed and how does it work?

The root cause is that we suppose there is only one volume in one TiKV when we sequence the pvc. When there are multiple volumes in one TiKV, the sequence of pvc will be disordered, which results in TiKV pods and restored pvc can't match.

So we group pvc of TiKV by volume name, we sequence pvc group by group.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanlins for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants