Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add make help cmd #5099

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented Jun 27, 2023

What problem does this PR solve?

add make help command. result:

image

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@csuzhangxc
Copy link
Member

@yyzxw thanks for your great contributor, please fix the CI by adding a newline at the end of the Makefile file.

@yyzxw yyzxw force-pushed the feature/add-make-help-cmd branch from 8fd35bf to dfc505e Compare June 27, 2023 09:57
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-28 01:53:48.633170286 +0000 UTC m=+758994.034420720: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 28, 2023
@csuzhangxc csuzhangxc merged commit fc52561 into pingcap:master Jun 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants