Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiproxy: revert enable SSL by default #5084

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jun 20, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@xhebox xhebox requested a review from csuzhangxc June 20, 2023 11:31
@ti-chi-bot ti-chi-bot bot added the size/S label Jun 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-20 11:33:34.837939436 +0000 UTC m=+102580.239189886: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 20, 2023
@xhebox
Copy link
Contributor Author

xhebox commented Jun 20, 2023

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@xhebox: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@xhebox: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #5084 (647461d) into master (0015c82) will increase coverage by 7.62%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5084      +/-   ##
==========================================
+ Coverage   57.42%   65.05%   +7.62%     
==========================================
  Files         246      250       +4     
  Lines       28585    31956    +3371     
==========================================
+ Hits        16415    20788    +4373     
+ Misses      10577     9511    -1066     
- Partials     1593     1657      +64     
Flag Coverage Δ
e2e 47.62% <0.00%> (?)
unittest 57.43% <0.00%> (+0.01%) ⬆️

@xhebox
Copy link
Contributor Author

xhebox commented Jun 20, 2023

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@xhebox: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@xhebox: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 4f37877 into pingcap:master Jun 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants