Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(volume): fix panic bug when enable ModifyVolume feature (#5058) #5082

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5058

What problem does this PR solve?

Fix #4990
Fix #5011

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hanlins. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #5082 (0e77011) into release-1.4 (460ffca) will increase coverage by 8.96%.
The diff coverage is 72.44%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4    #5082      +/-   ##
===============================================
+ Coverage        58.85%   67.81%   +8.96%     
===============================================
  Files              227      231       +4     
  Lines            26268    29424    +3156     
===============================================
+ Hits             15460    19954    +4494     
+ Misses            9324     7946    -1378     
- Partials          1484     1524      +40     
Flag Coverage Δ
e2e 52.84% <53.06%> (?)
unittest 58.91% <41.30%> (+0.05%) ⬆️

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-basic

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-tngm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-tngm cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 22, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 22, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 22, 2023

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 22, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-tikv-scale-simultaneously

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 22, 2023

@csuzhangxc: The label(s) /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 22, 2023

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc csuzhangxc merged commit e98d820 into pingcap:release-1.4 Jun 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants