Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a running VolumeBackup, backup CRs are deleted, but metadata and EBS snapshots are still remained #5159

Closed
WangLe1321 opened this issue Jul 10, 2023 · 2 comments · Fixed by #5199
Closed

Delete a running VolumeBackup, backup CRs are deleted, but metadata and EBS snapshots are still remained #5159

WangLe1321 opened this issue Jul 10, 2023 · 2 comments · Fixed by #5199
Labels
area/ebs-br severity/major type/bug Something isn't working

Comments

@WangLe1321
Copy link
Contributor

Bug Report

What version of Kubernetes are you using?

release-1.5

What version of TiDB Operator are you using?

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?

What's the status of the TiDB cluster pods?

What did you do?

  1. create a VolumeBackup with cleanPolicy: Delete
  2. wait the backup in the data plane initialize complete and start running 2nd phase
  3. delete the VolumeBackup CR

What did you expect to see?

VolumeBackup CR in control plane and backup CR in data plane are all deleted, metadata and EBS snapshots are also deleted.

What did you see instead?

VolumeBackup CR in control plane and backup CR in data plane are all deleted, but metadata and EBS snapshots aren't deleted.
@WangLe1321 WangLe1321 added type/bug Something isn't working area/ebs-br labels Jul 10, 2023
@BornChanger
Copy link
Contributor

BornChanger commented Jul 11, 2023 •
edited
Loading

Need to repro and to check operator cleanup logic

@BornChanger BornChanger mentioned this issue Jul 24, 2023
Open
@BornChanger
Copy link
Contributor

I think the problem should be fixed by #5199. Please double check. @WangLe1321

@BornChanger BornChanger mentioned this issue Jul 27, 2023
Merged
10 tasks
@ti-chi-bot ti-chi-bot mentioned this issue Jul 28, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ebs-br severity/major type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ebs br: fail delete cr operation if backup meta is missing BornChanger/tidb-operator
2 participants
@WangLe1321 @BornChanger