Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: modify resource manager owner to PD #1262

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Sep 2, 2024

Signed-off-by: husharp [email protected]

modify resource manager owner to PD

Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from JmPotato September 2, 2024 09:56
@HuSharp HuSharp requested review from wuhuizuo and removed request for JmPotato September 2, 2024 09:56
@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 2, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 2, 2024

@nolouch @rleungx @JmPotato PTAL, thx!

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Sep 2, 2024

/cc @zhangjinpeng87 @overvenus

OWNERS_ALIASES Outdated Show resolved Hide resolved
OWNERS_ALIASES Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Sep 2, 2024
Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, overvenus, rleungx, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 4, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 4, 2024
Copy link

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 10:06:50.51173711 +0000 UTC m=+266135.029790036: ☑️ agreed by rleungx.
  • 2024-09-03 02:26:28.395477586 +0000 UTC m=+324912.913530511: ☑️ agreed by JmPotato.
  • 2024-09-04 01:01:59.61157152 +0000 UTC m=+406244.129624518: ✖️🔁 reset by HuSharp.

Copy link

ti-chi-bot bot commented Sep 4, 2024

New changes are detected. LGTM label has been removed.

@ti-chi-bot ti-chi-bot added the lgtm label Sep 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit ed6867b into pingcap:master Sep 4, 2024
5 checks passed
@HuSharp HuSharp deleted the modify_owner branch September 4, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants