Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: remove beta from serverless docs #14086

Merged
merged 8 commits into from
Jul 5, 2023

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

remove beta from serverless docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

@ran-huang ran-huang added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. labels Jul 3, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2023
@ran-huang ran-huang marked this pull request as ready for review July 3, 2023 03:14
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@@ -26,7 +26,7 @@ We are constantly filling in the feature gaps between TiDB Serverless and TiDB D

### Transaction

- The total size of a single transaction is set to no more than 10 MB on TiDB Serverless during the beta phase.
- The total size of a single transaction is set to no more than 10 MB on TiDB Serverless during the beta phase. <!--To be confirmed-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this limitation still applicable to GA?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This limitation doc will be updated by xiaoguang in a separate PR.

@@ -244,5 +244,5 @@ test> SELECT * FROM sf_account;

- If anything goes wrong, you can navigate to the [CloudWatch](https://console.aws.amazon.com/cloudwatch/home) page on the AWS Management Console to get logs.
- The steps in this document are based on [Building custom connectors using the Amazon AppFlow Custom Connector SDK](https://aws.amazon.com/blogs/compute/building-custom-connectors-using-the-amazon-appflow-custom-connector-sdk/).
- [TiDB Serverless](https://docs.pingcap.com/tidbcloud/select-cluster-tier#tidb-serverless-beta) is **NOT** a production environment.
- [TiDB Serverless](https://docs.pingcap.com/tidbcloud/select-cluster-tier#tidb-serverless) is **NOT** a production environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA means now it can be a production env.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll delete this line.

tidb-cloud/select-cluster-tier.md Show resolved Hide resolved
@@ -26,7 +26,7 @@ We are constantly filling in the feature gaps between TiDB Serverless and TiDB D

### Transaction

- The total size of a single transaction is set to no more than 10 MB on TiDB Serverless during the beta phase.
- The total size of a single transaction is set to no more than 10 MB on TiDB Serverless during the beta phase. <!--To be confirmed-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This limitation doc will be updated by xiaoguang in a separate PR.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2023

@shizn: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Ran <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-04 02:41:08.519072957 +0000 UTC m=+85300.452706379: ☑️ agreed by hfxsd.

@ran-huang ran-huang added the lgtm label Jul 5, 2023
@ran-huang
Copy link
Contributor Author

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 5, 2023
@ran-huang
Copy link
Contributor Author

/verify

@ti-chi-bot ti-chi-bot bot merged commit 57337c1 into pingcap:release-6.5 Jul 5, 2023
5 of 6 checks passed
@ran-huang ran-huang deleted the cloud/rm-beta-serverless branch July 5, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants