Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: add Beta to metrics integration docs #14053

Merged
merged 6 commits into from
Jul 4, 2023

Conversation

qqqdan
Copy link
Contributor

@qqqdan qqqdan commented Jun 29, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qqqdan qqqdan requested a review from qiancai June 29, 2023 13:06
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 29, 2023
@qqqdan qqqdan changed the base branch from master to release-6.5 June 29, 2023 13:07
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 29, 2023
@hfxsd hfxsd added translation/no-need No need to translate this PR. for-cloud-release This PR is related to TiDB Cloud release. and removed missing-translation-status This PR does not have translation status info. labels Jun 30, 2023
@hfxsd hfxsd changed the title Update metrics integration doc cloud: add Beta to metrics integration docs Jun 30, 2023
@@ -248,13 +248,13 @@
- [Airbyte](/tidb-cloud/integrate-tidbcloud-with-airbyte.md)
- [Amazon AppFlow](/develop/dev-guide-aws-appflow-integration.md)
- [Cloudflare](/tidb-cloud/integrate-tidbcloud-with-cloudflare.md)
- [Datadog](/tidb-cloud/monitor-datadog-integration.md)
- [Datadog (Beta)](/tidb-cloud/monitor-datadog-integration.md)
Copy link
Collaborator

@qiancai qiancai Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

左侧目录 Datadog 后面可以不加 Beta 吗,看起来误以为是 Datadog 是 Beta

Comment on lines 256 to 257
- [New Relic (Beta)](/tidb-cloud/monitor-new-relic-integration.md)
- [Prometheus and Grafana (Beta)](/tidb-cloud/monitor-prometheus-and-grafana-integration.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

tidb-cloud/monitor-prometheus-and-grafana-integration.md Outdated Show resolved Hide resolved
tidb-cloud/monitor-new-relic-integration.md Outdated Show resolved Hide resolved
tidb-cloud/monitor-datadog-integration.md Outdated Show resolved Hide resolved
tidb-cloud/third-party-monitoring-integrations.md Outdated Show resolved Hide resolved
tidb-cloud/third-party-monitoring-integrations.md Outdated Show resolved Hide resolved
tidb-cloud/third-party-monitoring-integrations.md Outdated Show resolved Hide resolved
tidb-cloud/third-party-monitoring-integrations.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-04 01:22:38.660332126 +0000 UTC m=+80590.593965537: ☑️ agreed by qiancai.
  • 2023-07-04 06:30:08.4236429 +0000 UTC m=+99040.357276314: ☑️ agreed by hfxsd.

@qiancai qiancai added the area/tidb-cloud This PR relates to the area of TiDB Cloud. label Jul 4, 2023
@qiancai
Copy link
Collaborator

qiancai commented Jul 4, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4ccdae9 into release-6.5 Jul 4, 2023
@Oreoxmt Oreoxmt deleted the update-metrics-integration-doc branch May 28, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants