Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add encode password description for ticdc doc #14042

Merged
merged 5 commits into from
Jul 3, 2023
Merged

add encode password description for ticdc doc #14042

merged 5 commits into from
Jul 3, 2023

Conversation

ran-huang
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 29, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2023
@ran-huang
add translation
ac74d2a 
Signed-off-by: Ran <[email protected]>
@ran-huang ran-huang requested a review from qiancai June 29, 2023 07:29
qiancai
qiancai reviewed Jun 30, 2023
View reviewed changes
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other /lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-30 10:10:17.726475637 +0000 UTC m=+80301.101053483: ☑️ agreed by qiancai.

@ran-huang ran-huang added the lgtm label Jul 3, 2023
@ran-huang
Copy link
Contributor Author

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit a59fa29 into pingcap:master Jul 3, 2023
6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14065.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2023
Merged
16 tasks
@ran-huang ran-huang deleted the update-cdc-doc-13424 branch July 3, 2023 01:31
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #14066.

@ran-huang ran-huang added needs-cherry-pick-release-7.0 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14067.

This was referenced Jul 3, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14068.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #14069.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@ti-chi-bot
add encode password description for ticdc doc (#14042) (#14067)
0490e61
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@ti-chi-bot
add encode password description for ticdc doc (#14042) (#14065)
c721799
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@ti-chi-bot
add encode password description for ticdc doc (#14042) (#14066)
6475099
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@ti-chi-bot
add encode password description for ticdc doc (#14042) (#14068)
c1e8297
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2023
@ti-chi-bot
add encode password description for ticdc doc (#14042) (#14069)
70ca369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @ti-chi-bot @qiancai