Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include warning in tidb control #14041

Merged
merged 4 commits into from
Jul 4, 2023
Merged

include warning in tidb control #14041

merged 4 commits into from
Jul 4, 2023

Conversation

songrijie
Copy link
Contributor

@songrijie songrijie commented Jun 29, 2023 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Include warning messages to notify customers. We don't recommend to use tidb-ctl in application design.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2023
@songrijie songrijie mentioned this pull request Jun 29, 2023
Merged
17 tasks
lilin90
lilin90 reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 3, 2023
lilin90
lilin90 reviewed Jul 3, 2023
View reviewed changes
tidb-control.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jul 3, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 3, 2023
@lilin90 lilin90 added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jul 3, 2023
lilin90
lilin90 reviewed Jul 4, 2023
View reviewed changes
tidb-control.md Outdated Show resolved Hide resolved
This was referenced Jul 4, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-03 02:29:20.297081327 +0000 UTC m=+50191.935881119: ☑️ agreed by lilin90.
  • 2023-07-04 09:27:33.040342158 +0000 UTC m=+109684.973975585: ☑️ agreed by tiancaiamao.

@lilin90
Copy link
Member

lilin90 commented Jul 4, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 4, 2023
@ti-chi-bot ti-chi-bot bot merged commit 347d8ce into master Jul 4, 2023
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #14109.

This was referenced Jul 4, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #14110.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14111.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #14112.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #14113.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14114.

This was referenced Jul 4, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14115.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
include warning in tidb control (#14041) (#14109)
8c63f74
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
include warning in tidb control (#14041) (#14112)
18f51d9
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
include warning in tidb control (#14041) (#14114)
76dfbf2
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
include warning in tidb control (#14041) (#14115)
d6d0791
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
include warning in tidb control (#14041) (#14113)
cf3b3e5
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
include warning in tidb control (#14041) (#14111)
660d6b0
ti-chi-bot bot pushed a commit that referenced this pull request Jul 5, 2023
@ti-chi-bot
include warning in tidb control (#14041) (#14110)
a5131b2
@lilin90 lilin90 deleted the include-warning-msg-for-tidb-ctl branch August 7, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@songrijie @lilin90 @ti-chi-bot @tiancaiamao