-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
region: update region-size from 96MB to 256MB. #18336
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: lucasliang <[email protected]>
Hi @LykxSassinator. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @qiancai |
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
As discussed offline, please remove the |
|
||
> **注意:** | ||
> | ||
> 从 v8.4.0 开始,Region 的默认值从 96 MiB 调整为 256 MiB。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For deployments upgraded from a prior version, is there anything to be aware of?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already specified in "/tune-region-performance.md".
Signed-off-by: lucasliang <[email protected]>
@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Lilian Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Co-authored-by: xixirangrang <[email protected]>
First-time contributors' checklist
What is changed, added or deleted? (Required)
Ref: tikv/tikv#17309
This pr specify the newly updated configuration change to the default value of
region-size
, changing it from96MB
to256MB
.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?