Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add batch operation for creating/dropping binding by specifying digests #18335

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

time-and-fate
Copy link
Member

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2024
@lilin90 lilin90 self-assigned this Aug 12, 2024
@lilin90 lilin90 added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Aug 12, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 12, 2024
@lilin90 lilin90 added the v8.3 label Aug 12, 2024
@lilin90 lilin90 self-requested a review August 12, 2024 03:45
Copy link

ti-chi-bot bot commented Aug 12, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sql-plan-management.md Outdated Show resolved Hide resolved
sql-plan-management.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-create-binding.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-create-binding.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-drop-binding.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-drop-binding.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-drop-binding.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 13, 2024
@lilin90 lilin90 requested a review from hfxsd August 13, 2024 04:03
Comment on lines 37 to 39
你可以根据 SQL 或历史执行计划创建绑定。

根据历史执行计划创建绑定时,你需要指定相应的 Plan Digest,既可以通过字符串字面量来指定,也可以通过字符串类型的用户变量来指定。你可以通过指定多个 Plan Digest 来同时为多个语句创建绑定,此时你可以指定多个字符串,同时每个字符串也可以包含多个 digest,注意字符串之间和 digest 之间均需使用逗号隔开。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
你可以根据 SQL 或历史执行计划创建绑定。
根据历史执行计划创建绑定时,你需要指定相应的 Plan Digest,既可以通过字符串字面量来指定,也可以通过字符串类型的用户变量来指定。你可以通过指定多个 Plan Digest 来同时为多个语句创建绑定,此时你可以指定多个字符串,同时每个字符串也可以包含多个 digest,注意字符串之间和 digest 之间均需使用逗号隔开。
你可以根据 SQL 或历史执行计划创建绑定。根据历史执行计划创建绑定时,你需要指定相应的 Plan Digest,此时:
- 既可以通过字符串字面量来指定,也可以通过字符串类型的用户变量来指定。
- 可以通过指定多个 Plan Digest 来同时为多个语句创建绑定,此时你可以指定多个字符串,同时每个字符串也可以包含多个 digest,注意字符串之间和 digest 之间均需使用逗号隔开。

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 13, 2024
Copy link

ti-chi-bot bot commented Aug 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-13 04:02:40.94825521 +0000 UTC m=+240645.651724858: ☑️ agreed by lilin90.
  • 2024-08-13 13:19:05.88537738 +0000 UTC m=+274030.588847020: ☑️ agreed by hfxsd.

@lilin90
Copy link
Member

lilin90 commented Aug 15, 2024

/approve

Copy link

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit db29423 into pingcap:master Aug 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants