Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting binary encoding used with Canal-JSON #14774

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Aug 14, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

I added documentation that describes how the binary data found in BINARY, VARBINARY, and BLOB columns is encoded when using the Canal-JSON format.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

None

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Aug 14, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2023
ticdc/ticdc-canal-json.md Outdated Show resolved Hide resolved
@nongfushanquan
Copy link

/cc @sdojjy

@ti-chi-bot ti-chi-bot bot requested a review from sdojjy August 14, 2023 10:16
ticdc/ticdc-canal-json.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

@sdojjy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd self-requested a review September 12, 2023 09:49
@qiancai qiancai added the area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. label Sep 12, 2023
@qiancai qiancai self-assigned this Sep 12, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 06:59:20.540542019 +0000 UTC m=+68726.508130068: ☑️ agreed by hfxsd.

@qiancai
Copy link
Collaborator Author

qiancai commented Oct 10, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit dda4ee6 into pingcap:master Oct 10, 2023
5 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15171.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #15172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants