Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add feedback api for interactions #60

Merged
merged 2 commits into from
Mar 28, 2024
Merged

api: add feedback api for interactions #60

merged 2 commits into from
Mar 28, 2024

Conversation

lucklove
Copy link
Member

Why are these changes needed?

Related issue number

Closes #56

Checks

  • I've included any doc changes needed for https://github.com/pingcap/LinguFlow/.
  • I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • I've made sure all auto checks have passed.

api/application.py Show resolved Hide resolved
Copy link
Collaborator

@freedeaths freedeaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly langfuse didn't provide any specified exception so that we can do nothing now although it's a little weird to return success always.

cc @lilyjazz

Copy link
Member

@lilyjazz lilyjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucklove lucklove merged commit fe8a94c into main Mar 28, 2024
1 check passed
@lucklove lucklove deleted the feedback branch March 28, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: support feedback api
3 participants