Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt readme #55

Merged
merged 4 commits into from
Mar 28, 2024
Merged

opt readme #55

merged 4 commits into from
Mar 28, 2024

Conversation

lilyjazz
Copy link
Member

Why are these changes needed?

opt readme

Related issue number

Checks

  • I've included any doc changes needed for https://github.com/pingcap/LinguFlow/.
  • I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • I've made sure all auto checks have passed.

@lilyjazz lilyjazz marked this pull request as draft March 26, 2024 09:55
@lilyjazz
Copy link
Member Author

This PR requires some changes from #49. We need to wait for #49 to be merged before continuing with the modifications.

@lilyjazz lilyjazz marked this pull request as ready for review March 28, 2024 07:40
@lilyjazz lilyjazz requested a review from lucklove March 28, 2024 07:40
lucklove
lucklove approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucklove lucklove merged commit a153d97 into main Mar 28, 2024
1 check passed
@lucklove lucklove deleted the readme branch March 28, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove lucklove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilyjazz @lucklove @shhdgit