Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: CSV Data Source with skipFirstRow should use row headings rather than row index #412

Open
cancan101 opened this issue Jun 3, 2024 · 1 comment

Comments

@cancan101
Copy link

cancan101 commented Jun 3, 2024

Feature description

Currently the column index for a CSV file (with headings, i.e. skipFirstRow: true) is serialized such that if the column ordering changes, the import will fail.

Examples are idDataIndex and dataSourceIndex in the config.

The same issues applies to loading XLSX files.

The current config makes the loaders not robust to any sort of column additions / reordering.

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant