Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: source empty check fails on field inside of object brick #398

Open
jensschaerer opened this issue Feb 25, 2024 · 1 comment
Open

Comments

@jensschaerer
Copy link

jensschaerer commented Feb 25, 2024

Expected behavior

Don't set the variable, when If source is empty is not checked and skip that record

Actual behavior

When "If source is empty" is not checked while trying to import a value to an object brick field, the importer fails, no matter if the value is empty or not
image

Error processing element: 1001, 1001-38, 38, , , 38, , , 1ucfirst(): Argument #1 ($string) must be of type string, null given

Steps to reproduce

see screenshot

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant