From e45c8ce4f75ea015ee817292557af391c3bec2be Mon Sep 17 00:00:00 2001 From: Jonathan-Gore <43797248+Jonathan-Gore@users.noreply.github.com> Date: Wed, 10 Apr 2024 22:05:51 -0700 Subject: [PATCH 1/2] Added SimpleRadial camera model to colmap.cpp Added the SimpleRadial camera model to colmap.cpp from https://github.com/colmap/colmap/blob/0ea2d5ceee1360bba427b2ef61f1351e59a46f91/src/colmap/sensor/models.h#L235 Copied syntax found in SimplePinhole, copying fy=fx for the models with only one focal length parameter. --- colmap.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/colmap.cpp b/colmap.cpp index fd7aeab..4c73409 100644 --- a/colmap.cpp +++ b/colmap.cpp @@ -53,6 +53,12 @@ InputData inputDataFromColmap(const std::string &projectRoot){ cam->fy = readBinary(camf); cam->cx = readBinary(camf); cam->cy = readBinary(camf); + }else if (model == SimpleRadial){ + cam->fx = readBinary(camf); + cam->fy = cam->fx; + cam->cx = readBinary(camf); + cam->cy = readBinary(camf); + cam->k = readBinary(camf); }else if (model == OpenCV){ cam->fx = readBinary(camf); cam->fy = readBinary(camf); From a2a850559ee8900306f07d9f4cdb1acabe86ba56 Mon Sep 17 00:00:00 2001 From: Jonathan-Gore <43797248+Jonathan-Gore@users.noreply.github.com> Date: Thu, 11 Apr 2024 19:00:28 -0700 Subject: [PATCH 2/2] Update colmap.cpp Changed k -> k1 so it would be a valid parameter. --- colmap.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/colmap.cpp b/colmap.cpp index 4c73409..5bad19e 100644 --- a/colmap.cpp +++ b/colmap.cpp @@ -58,7 +58,7 @@ InputData inputDataFromColmap(const std::string &projectRoot){ cam->fy = cam->fx; cam->cx = readBinary(camf); cam->cy = readBinary(camf); - cam->k = readBinary(camf); + cam->k1 = readBinary(camf); }else if (model == OpenCV){ cam->fx = readBinary(camf); cam->fy = readBinary(camf);