Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple alternative to support iCloud China mainland domain #428

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Simple alternative to support iCloud China mainland domain #428

wants to merge 4 commits into from

Conversation

MatrixDai
Copy link

Proposed change

Support China mainland domain.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:

export DOMAIN=cn
icloud [email protected]

Additional information

  • This PR switch API endpoints for iCloud China based on the environment variable DOMAIN, so that the library support iCloud China seamless.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

@landall
Copy link

landall commented Jun 10, 2023

Great Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatrixDai @landall