Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How compares to mriphysio ? #438

Open
yarikoptic opened this issue Feb 8, 2023 · 3 comments
Open

How compares to mriphysio ? #438

yarikoptic opened this issue Feb 8, 2023 · 3 comments
Labels
Discussion Discussion of a concept or implementation. Need to stay always open.

Comments

@yarikoptic
Copy link
Contributor

I was told about https://github.com/adolphslab/mriphysio by @jmtyszka.

  • Wondered who phys2bids compares.
  • Might be nice to have "comaprison" table of a kind in README.md to other similar/related tools

My greedy rationale: We are considering a Siemens WiP to package/send physio data as DICOMs. Now need to figure out what would be the best tool for us to do then conversion from DICOMs, hence "shopping around".

@yarikoptic yarikoptic added the Discussion Discussion of a concept or implementation. Need to stay always open. label Feb 8, 2023
@smoia
Copy link
Member

smoia commented Feb 8, 2023

Hey there,

we don't support SIEMENS physiological data yet.
I'd say that the first step was to adapt the workflow to read files from MRIs in general (mainly because they lack a trigger but they are coherent with the runs, which is not the case for everything else). @nw-duncan covered it for GE files.
So we can now integrate a SIEMENS conversion system as well.
I'd be very happy if @jmtyszka you'd like to help us with it!
Alternatively, I think @marcelzwiers has another method we could try to integrate - and maybe we need to integrate both, as they might be for different SIEMENS data structures.

@marcelzwiers
Copy link
Contributor

Hi there, what I implemented was the physio data of the CMRR puls-sequence (which is a custom-made sequence for Siemens scanners), I don't know about the Siemens product sequence

@yarikoptic
Copy link
Contributor Author

and I forgot to ask @pvelasco about https://github.com/cbinyu/bidsphysio -- would that one work on "stock" Siemens WiP DICOMs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Discussion of a concept or implementation. Need to stay always open.
Projects
None yet
Development

No branches or pull requests

3 participants