Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing of false negatives and resolving to multiple nodes #57

Open
gaurav opened this issue Aug 12, 2019 · 0 comments
Open

Improve testing of false negatives and resolving to multiple nodes #57

gaurav opened this issue Aug 12, 2019 · 0 comments
Labels
programming only No discussion necessary; just pure programming needed

Comments

@gaurav
Copy link
Member

gaurav commented Aug 12, 2019

JPhyloref's TestCommand currently considers a phyloreference to have been successfully tested if it resolves to one or more nodes, of which at least one node expects to be resolved to this phyloreference. We should improve this by:

  • Flagging a test failure when a phylogeny contains a node that expects this phyloreference to be resolved to it, but that the phyloreference does not resolve to (i.e. a false negative).
  • Flagging a test failure when a phyloreference resolves to any node that does not expect this phyloreference to resolve to it.

Note that this is less urgent than it appears, since TestCommand is only used as part of the Clade Ontology, not the Authoring Tool.

@gaurav gaurav added the programming only No discussion necessary; just pure programming needed label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
programming only No discussion necessary; just pure programming needed
Projects
None yet
Development

No branches or pull requests

1 participant