Write out phyloreference details during testing #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
force-pushed
the
report_phyloref_details
branch
from
7c6dd5a
to
3e50fa9
Compare
gaurav
force-pushed
the
report_phyloref_details
branch
from
6c94214
to
a8a072a
Compare
We previously ran `npm install` in the Curation Tool directory, but since we no longer include the Curation Tool, this instruction is now moot.
Using index-based lookups relies on JPhyloRef returning phylorefs in a particular order, which it doesn't.
gaurav
force-pushed
the
report_phyloref_details
branch
from
a8a072a
to
5479b5a
Compare
gaurav
force-pushed
the
replace_submodule_with_npm
branch
from
2b400a0
to
6c76328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently have a good way to summarize everything that is currently in the Clade Ontology (#34). This PR will attempt to write out that information during testing, so we have a record of what the definitions being tested are, and whether or not they passed testing. This may also help with debugging -- if one type of phyloreference fails during, that might help isolate which part of the process is broken.
Do not merge: I'm not happy with the way this looks in the Travis output, and I'll keep working on this to see if I can make it better.
WIP