Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing of long-running PHYX files #36

Open
gaurav opened this issue Jun 19, 2018 · 1 comment
Open

Improve testing of long-running PHYX files #36

gaurav opened this issue Jun 19, 2018 · 1 comment

Comments

@gaurav
Copy link
Member

gaurav commented Jun 19, 2018

There are some PHYX files that take too long to test on Travis. My plan for dealing with those is as follows:

  1. PHYX files that can be tested quickly are kept in a phyx directory and are automatically and continuously tested using Travis CI. We need to ensure that these files are representative of the different kinds of phyloreferences we have. We should try to keep the time taken to run all these files to within 60 minutes (we're currently at around 30 minutes).
  2. PHYX files that take longer to run are kept in a phyx_too_slow directory. There should be a mark (i.e. a test command line option, such as py.test tests/ -m runslow) that tests all the slow-running phyloreferences.
  3. For ad hoc testing, phyloreferences can be reasoned over in Protege and then exported as an OWL ontology to be used with jphyloref's --no-reasoner. We should also create a script that tests a particular PHYX file.
  4. All these changes should be documented in the README.md file when implemented.

Our long-term goal is to speed up reasoning so that more files can be included in the Travis run, but this should be good enough for the short-to-medium term (i.e. until after TDWG 2018).

@gaurav
Copy link
Member Author

gaurav commented Jun 22, 2018

Another possibility: we could store a Gzipped file of the reasoned ontology and run that in the test suite. Since reasoning is the slowest part of the process, this should run pretty quickly. The one long-running test file we have is around 800kb as a Gzipped RDF/XML file, well under Github's 50MB limit; we might be able to make it smaller by using Turtle or another export format.

gaurav added a commit that referenced this issue Jun 22, 2018
Added phyloreferences from [Wojciechowski, 2003](http://dx.doi.org/10.1016/j.sajb.2013.06.017), using the phyloreference state system to mark phyloreferences that cannot be tested (phyloref/klados#25, phyloref/klados#66). This PHYX file takes too long to process to be included into the test suite, so for now I'm placing it into its own directory (`testcases_too_slow`) -- we will figure out the best way to continuously test them in #36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant