Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical callbacks clobbered when passing options parameter #62

Open
rossj opened this issue Mar 6, 2013 · 0 comments
Open

Canonical callbacks clobbered when passing options parameter #62

rossj opened this issue Mar 6, 2013 · 0 comments

Comments

@rossj
Copy link

rossj commented Mar 6, 2013

Do to the way parameters are normalized, passing an options parameter as well as a cb parameter results in the callback being set to false.

For example:

var doc = { data : 'helo' };

// This works
elastic.index('index', 'type', doc, 'id1', function() {...});

// This does not
elastic.index('index', 'type', doc, 'id1', { parent: 'blah' }, function() {...});

I might have time to do a PR in a couple days.

hmalphettes added a commit to hmalphettes/node-elasticsearch-client that referenced this issue Apr 4, 2013
Extensive tests for the es#bulk operation
Ability to pass use the endpoints /{index}/_bulk,
and {index}/{type}/_bulk by passing those parameters
in the options as _index and _type
Fixed the pulling out of the options arguments
when it is not defined (phillroGH-62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant