Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: limit image width with a setting #22

Open
james-xli opened this issue May 10, 2024 · 6 comments
Open

enhancement: limit image width with a setting #22

james-xli opened this issue May 10, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@james-xli
Copy link
Contributor

First, thanks for making this plugin. It's great to be able to use my Supernote with Obsidian.

When viewing notes, I would like to limit the width of the page images so that they don't appear too large. (I have a Nomad, which is physically not very large.) At normal desktop window sizes, the page images tend to appear very zoomed in, requiring a lot of scrolling. My current workaround is to make my Obsidian window very narrow.

Not sure if there is an existing solution to this, or if this is already in your plans.

Thank you!

@philips
Copy link
Owner

philips commented May 10, 2024

That is odd. Are you using a custom theme with Obsidian? I am using the default theme on macOS with version 1.5.12 and the images are scaled to the window size.

@philips philips added the question Further information is requested label May 10, 2024
@james-xli
Copy link
Contributor Author

Hi, thanks for the quick response!

I am also using the default theme on macOS with Obsidian v1.5.12.

Let me try to clarify my question. When I make my Obsidian window narrow (screenshot below), my note images are small enough that I can see the whole page in my window, and the handwriting size is not much bigger than the text size in Obsidian. It is easy to scroll through multiple pages.

Screenshot 2024-05-10 at 7 24 18 AM

When I make the Obsidian window wider, then the note images scale to the window size as you described. I can see how this might be useful sometimes, but for my use it makes the notes harder to scan and scroll through because they are so large:

Screenshot 2024-05-10 at 7 24 39 AM

So I'm looking for a way to limit how big the page images can scale, so that I can scan and scroll through multiple pages more quickly.

Just a usability feature suggestion, feel free to ignore or deprioritize :)

@philips
Copy link
Owner

philips commented May 10, 2024

I added an FAQ entry on this. I suggest you try the Mousewheel Image zoom plugin: https://github.com/philips/supernote-obsidian-plugin/tree/main?tab=readme-ov-file#faq

@philips philips closed this as completed May 10, 2024
@james-xli
Copy link
Contributor Author

Hi, thanks for the suggestion and FAQ update!

I gave the plugin a try; it works great on images embedded in .md files, but it doesn't seem to have any effect on previews directly in .note files. My question is about .note files, not .md files with images embedded. Sorry if that context wasn't clear before!

I have some free time today so I might try forking your repo and tinkering a bit. Will share here if my efforts bear any fruit!

@philips
Copy link
Owner

philips commented May 12, 2024

@james-xli I think the trick with the .note preview is that there isn't a natural spot to store the adjusted zoom level in the .note as I only have a .note parser not a .note generator. So, you would have this metadata, the zoom level, but no place to store it.

I guess I could have a max px setting in the settings pane and just let people specify a max. Would that accomplish your desire?

@james-xli
Copy link
Contributor Author

I think a max px width setting in the settings pane would be perfect! No need for it to be a per-note or per-image setting.

@philips philips changed the title Feature request: Limit page image width when viewing notes enhancement: limit image width with a setting May 13, 2024
@philips philips reopened this May 13, 2024
@philips philips added enhancement New feature or request good first issue Good for newcomers and removed question Further information is requested labels May 13, 2024
james-xli added a commit to james-xli/supernote-obsidian-plugin that referenced this issue May 13, 2024
Per issue philips#22, adds a max px width setting in the settings pane. Notes are still responsive to window size below the max width.
james-xli added a commit to james-xli/supernote-obsidian-plugin that referenced this issue Jun 9, 2024
Per issue philips#22, adds a max px width setting in the settings pane. Notes are still responsive to window size below the max width.
james-xli added a commit to james-xli/supernote-obsidian-plugin that referenced this issue Jun 9, 2024
Per issue philips#22, adds a max px width setting in the settings pane. Notes are still responsive to window size below the max width.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants