Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: improve load times for large notes #19

Open
AnthonyMcDougal opened this issue Apr 11, 2024 · 2 comments
Open

feature: improve load times for large notes #19

AnthonyMcDougal opened this issue Apr 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AnthonyMcDougal
Copy link

Large multi-page notes take a while (~30 sec? depending on length) to load, and this repeats every time the file is selected for the open pane.

  1. Is there a way to decrease this time?
  2. Is there a way to not repeat this every time the file is selected, or is exporting the image the only way?
@philips
Copy link
Owner

philips commented Apr 11, 2024

Yeah unfortunately parsing the images is slow. I am sure there is a way to speed that up but I don’t know when I would have time to dig into that.

If someone were want to take a performance pass at the library the file is in here https://github.com/philips/supernote-typescript/blob/main/src/conversion.ts

@philips philips added the enhancement New feature or request label May 10, 2024
@philips
Copy link
Owner

philips commented May 13, 2024

Added generation of a cpuprofile to one of the tests to start to hunt this down: philips/supernote-typescript@57f19b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants