Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Wanted: more test files #1

Open
philips opened this issue Mar 1, 2024 · 15 comments
Open

Help Wanted: more test files #1

philips opened this issue Mar 1, 2024 · 15 comments

Comments

@philips
Copy link
Owner

philips commented Mar 1, 2024

I could use some simple and small test .note files from supernote X2 devices and some with text too. I believe the single test file I have is from X series devices but I don't know as I don't have either.

@isolatedvirus
Copy link

link to test files are here:
https://file.io/nZpssgTjMnT0

There are 5 files total
-4 .note files
-1 .doc file

Files were created using the supernote nomad running Chauvet 3.15.27

'20240303_155152.doc' contains a line of text.
'blank template.note' is just a blank .note
'dot template.note' is a blank note using the 5mm dot background
'blank-2p.note' contains two pages of handwritten text, and demos the available writing tools. This was done using the blank background template, and contains a link to the first page on the second page.
'blank-shapes-and-RTR.note' conains a single page of shapes, patterns, and handwritten text. Headings and keyword highlighting included in file. This file was created using Real Time Recognition (allows export of handwritten notes as text within the nomad), with the blank background template.

If you need anything else, please let me know.

@philips
Copy link
Owner Author

philips commented Mar 3, 2024

Thanks! Did you try the plugin too? Did it work?

@philips
Copy link
Owner Author

philips commented Mar 4, 2024

Thanks @isolatedvirus I added these to the test suite and see that they currently fail. I will try and fix that! https://github.com/philips/supernote-typescript/tree/nomad

  ● smoke › convert a note from a nomad Chauvet 3.15.27 with handwriting recognition to png pages

    TypeError: Cannot read properties of undefined (reading 'alpha')

      201 |     let newColor = encodedColor === -1 ? Color("transparent") : translation[encodedColor]
      202 |     let chunk: Buffer
    > 203 |     if (newColor.alpha() === 0) {
          |                  ^
      204 |       chunk = Buffer.from(new Uint8Array([0, 0, 0, 0]))
      205 |     } else {
      206 |       chunk = Buffer.from(new Uint8Array([...newColor.rgb().array(), ~~(255 * newColor.alpha())]))

      at RattaRLEDecoder.addColorBuffer (src/conversion.ts:203:18)
      at RattaRLEDecoder.decode (src/conversion.ts:176:14)
      at src/conversion.ts:46:34
          at Array.map (<anonymous>)
      at src/conversion.ts:45:8
          at Array.map (<anonymous>)
      at src/conversion.ts:42:16
      at src/conversion.ts:8:71

@philips
Copy link
Owner Author

philips commented Mar 4, 2024

@isolatedvirus Made a new release that extracts the text and images!

Square
Triangle
Circle
Star

nomad-3 15 27-blank-2p note-0
nomad-3 15 27-blank-2p note-1
nomad-3 15 27-blank-shapes-and-RTR note-0

@orhoncan
Copy link

orhoncan commented Mar 5, 2024

Hi,
I tried Obsidian importing with this note:
https://file.io/fN9NqG5QRohV

which looks like this in Obsidian:
image

which is fine in Nomad:
IMG_6660

@Zevoros-cyber
Copy link

Zevoros-cyber commented Mar 5, 2024

Very simple realtime note that is failing on 1.0.2. SN is A5X with 2.14.28. Obsidian is running on Windows 11 Home, v 23H2, Build 22631.3235.
20240304_154111 Obsidian Integration Test File.zip

@philips
Copy link
Owner Author

philips commented Mar 6, 2024

@orhoncan made a fix! philips/supernote-typescript@990230c

I want to figure out @Zevoros-cyber issue before cutting a new plugin release.

@Zevoros-cyber
Copy link

@philips , would you like a complex A5X test file? I can create one with various styles of links, headings, and keywords if you don't already have one to work with.

@philips
Copy link
Owner Author

philips commented Mar 6, 2024

@Zevoros-cyber This is the first time I have had a file with a custom background. I got it to work, I think.

a5x-2 14 28 note-0

@Zevoros-cyber
Copy link

@philips Sorry, I should have mentioned the custom background. I've been using it for so long that I forgot it was a custom! I do have a question about the display of the extracted image, however. The actual custom background is black lines on white (FFFFFF) background. Should the background post-processing from the plugin be gray (C8C8C8)?

@isolatedvirus
Copy link

isolatedvirus commented Mar 6, 2024 via email

@philips
Copy link
Owner Author

philips commented Mar 6, 2024

I uploaded 1.0.3 with fixes for your issues @Zevoros-cyber and @orhoncan. Please give it a try!

https://github.com/philips/obsidian-plugin-supernote/releases/tag/1.0.3

@philips
Copy link
Owner Author

philips commented Mar 6, 2024

@isolatedvirus that is odd.... I filed a bug about the general grayscale handling in the library here: philips/supernote-typescript#1

@Zevoros-cyber
Copy link

I uploaded 1.0.3 with fixes for your issues @Zevoros-cyber and @orhoncan. Please give it a try!

https://github.com/philips/obsidian-plugin-supernote/releases/tag/1.0.3

It's working perfectly! Of course, with my usually poor handwriting, I'm going to need to automate text cleanup in the md via a local gen AI model. I think that there should be plugins for that.

@philips
Copy link
Owner Author

philips commented Mar 6, 2024

Noice! Thanks for testing @Zevoros-cyber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants