Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model.frame() implementation for lcModel objects #119

Open
niekdt opened this issue Jun 30, 2022 · 0 comments
Open

model.frame() implementation for lcModel objects #119

niekdt opened this issue Jun 30, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@niekdt
Copy link
Collaborator

niekdt commented Jun 30, 2022

The model implementations would be more robust if they make use of model.frame() instead of the full dataset returned by model.data(). Here, model.frame() should output the columns needed by the respective model, even if the model was specified without a formula.

See the ideas in #115
@niekdt niekdt added the enhancement New feature or request label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niekdt