Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize the histogram implementation for it to be used in other screens #22

Open
AgustinVallejo opened this issue Sep 11, 2024 · 3 comments
Open

Generalize the histogram implementation for it to be used in other screens #22

AgustinVallejo opened this issue Sep 11, 2024 · 3 comments
Assignees
@AgustinVallejo

Comments

@AgustinVallejo
Copy link
Contributor

No description provided.

@AgustinVallejo AgustinVallejo self-assigned this Sep 12, 2024
@jbphet
Copy link
Collaborator

jbphet commented Sep 12, 2024

As part of this work it would probably be a good idea to start generalizing this histogram, since it is used in all three of the other screens (I believe).

@AgustinVallejo AgustinVallejo changed the title Improve the horizontal spacing of the histogram, specially for 10000 coins Improve the horizontal spacing of the histogram, especially for 10000 coins Sep 13, 2024
AgustinVallejo added a commit that referenced this issue Sep 13, 2024
@AgustinVallejo
Aligning horizontally histogram components, see #22
e240aed
@AgustinVallejo AgustinVallejo changed the title Improve the horizontal spacing of the histogram, especially for 10000 coins Generalize the histogram implementation for it to be used in other screens Sep 17, 2024
@AgustinVallejo
Copy link
Contributor Author

Unassigning. The generalization work can be done later when we start looking into the other screens.

@AgustinVallejo
Copy link
Contributor Author

For future reference, here's how the histogram should look across the Coins, Photons and Bloch screens:

Image

AgustinVallejo added a commit that referenced this issue Oct 4, 2024
@AgustinVallejo
Creating a parent class for the histogram, see #22
e15e50c
AgustinVallejo added a commit that referenced this issue Oct 23, 2024
@AgustinVallejo
Separating coins reference from the general histogram, see #22
0cc96b7
AgustinVallejo added a commit that referenced this issue Oct 23, 2024
@AgustinVallejo
Adding a general histogram for all screens, see #22
4ac500b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @AgustinVallejo