Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16214 delete getrelated #16215

Merged
merged 6 commits into from
Jul 31, 2023
Merged

T16214 delete getrelated #16215

merged 6 commits into from
Jul 31, 2023

Conversation

niden
Copy link
Member

@niden niden commented Nov 18, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model::delete to clear the reusable cache when deleting records using getRelated()

Thanks

@niden niden requested a review from Jeckerson November 18, 2022 16:02
@niden niden self-assigned this Nov 18, 2022
@niden niden added bug A bug report status: high High 5.0 The issues we want to solve in the 5.0 release labels Nov 18, 2022
@niden niden linked an issue Nov 18, 2022 that may be closed by this pull request
[BUG]: Calling delete() on model->getRelated() with reusable does not clear the cache #16214
Closed
@niden niden marked this pull request as draft November 18, 2022 23:18
@niden niden marked this pull request as ready for review July 31, 2023 13:15
@niden niden merged commit d33b505 into phalcon:5.0.x Jul 31, 2023
38 checks passed
@niden niden deleted the T16214-delete-getrelated branch July 31, 2023 16:48
@niden niden mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: high High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Calling delete() on model->getRelated() with reusable does not clear the cache
2 participants
@niden @Jeckerson